Re: [PATCH] [PATCH V2] bcache: fix wrong cache_misses statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/27/2017 07:39 PM, tang.junhui@xxxxxxxxxx wrote:
> From: "tang.junhui" <tang.junhui@xxxxxxxxxx>
> 
> Currently, Cache missed IOs are identified by s->cache_miss, but actually,
> there are many situations that missed IOs are not assigned a value for
> s->cache_miss in cached_dev_cache_miss(), for example, a bypassed IO
> (s->iop.bypass = 1), or the cache_bio allocate failed. In these situations,
> it will go to out_put or out_submit, and s->cache_miss is null, which leads
> bch_mark_cache_accounting() to treat this IO as a hit IO.
> 
> Signed-off-by: tang.junhui <tang.junhui@xxxxxxxxxx>

Reviewed-by: Michael Lyle <mlyle@xxxxxxxx>

Applied to my local tree for test.  Thanks!

-mpl
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux