Re: [PATCH] bcache: fix race in setting bdev state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Tang Junhui <tang.junhui@xxxxxxxxxx>

Hello Mike:

> How did you find this?  Did the race trigger at detach or was it through 
> code inspection?
I find this through code inspection.

> I need to analyze this more.  It looks correct on its own, but there are 
> a lot of atomic variables and the way they are used is complicated.
> 
> I'm inclined to think that detach should traverse the writeback lock for 
> safety.  It would be a lot less complicated to analyze what would 
> happen.  What do you think?
As Far as now, except this issue, I can't see any more race during detach,
so I don't think we need to take a writeback lock. Could you please show me 
what problem you worried about?

Regards,
Tang
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux