On Wed, Aug 09, 2017 at 09:39:09AM +0300, Nikolay Borisov wrote: > > > On 8.08.2017 09:00, Byungchul Park wrote: > > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > >>>>> + llist_for_each_entry_safe(cl, t, reverse, list) { > >>>> > >>>> Just wondering why not using llist_for_each_entry(), or you use the > >>>> _safe version on purpose ? > >>> > >>> If I use llist_for_each_entry(), then it would change the original > >>> behavior. Is it ok? > > Generally, _safe versions of list primitives is used when you are going > to perform removal in the iteration. I haven't looked at the code in > bcache but if it's removing entries from the list then _safe version is > required. If you are only iterating - then non-safe version is fine. Thank you~ :) -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html