I had the same feeling, and was reluctant to do so. The reason for making this change was that current code implicitly converts work_func_t to closure_fn, and it also depends on the offset and size of a few struct not being changed. So the patch was introduced essentially to solve that, and keep the impact small meanwhile. But as you pointed out, explicit casting is still bad too (was hoping it can be considered less bad at this situation). I will think of a better idea to handle this issue unless people agree that the current behaviour is safe. -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html