On 2017/5/9 上午9:18, tang.junhui@xxxxxxxxxx wrote: > Hello Coly, > > > Your catch is nice: > > > ＞ if you call ida_simple_get() like this, > > ＞ > > ＞ minor = ida_simple_get(&bcache_minor, 0, BCACHE_TO_IDA_MONIRS(MINORMASK > > ＞ + 1), GFP_KERNEL); > > ＞ > > ＞ The overflow should be removed. > > > But I think it is better to modified it as: > > minor = ida_simple_get(&bcache_minor, 0, BCACHE_TO_IDA_MONIRS(MINORMASK) > > + 1, GFP_KERNEL); > Sure, they are same, just use the way you want. > > Though this issue is not introduced by this patch, I would like to fix > it togother Thank you! > > in this patch, I will send a new patch later If you don't have any > question any more. Yes please, I don't have comment any more. -- Coly Li -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
