On Thu 09-02-17 14:19:16, Jan Kara wrote: > If blkdev_get_by_path() in register_bcache() fails, we try to lookup the > block device using lookup_bdev() to detect which situation we are in to > properly report error. However we never drop the reference returned to > us from lookup_bdev(). Fix that. > > Signed-off-by: Jan Kara <jack@xxxxxxx> Ping? This seems to have fallen through the cracks... Honza > --- > drivers/md/bcache/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 3a19cbc8b230..2a6a4a0520f6 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1964,6 +1964,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, > else > err = "device busy"; > mutex_unlock(&bch_register_lock); > + if (!IS_ERR(bdev)) > + bdput(bdev); > if (attr == &ksysfs_register_quiet) > goto out; > } > -- > 2.10.2 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
