在 2016/7/4 13:49, Coly Li 写道: > 在 16/7/4 上午9:23, Yijing Wang 写道: >> There is no return in continue_at(), update the documentation. >> > > Thanks. > > Acked-by: Coly Li <colyli@xxxxxxx> Thanks very much! > >> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx> >> --- >> drivers/md/bcache/closure.c | 2 +- >> drivers/md/bcache/closure.h | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c >> index 9eaf1d6..864e673 100644 >> --- a/drivers/md/bcache/closure.c >> +++ b/drivers/md/bcache/closure.c >> @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl) >> EXPORT_SYMBOL(closure_wait); >> >> /** >> - * closure_sync - sleep until a closure a closure has nothing left to wait on >> + * closure_sync - sleep until a closure has nothing left to wait on >> * >> * Sleeps until the refcount hits 1 - the thread that's running the closure owns >> * the last refcount. >> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h >> index 782cc2c..9b2fe2d 100644 >> --- a/drivers/md/bcache/closure.h >> +++ b/drivers/md/bcache/closure.h >> @@ -31,7 +31,8 @@ >> * passing it, as you might expect, the function to run when nothing is pending >> * and the workqueue to run that function out of. >> * >> - * continue_at() also, critically, is a macro that returns the calling function. >> + * continue_at() also, critically, requires a 'return' immediately following the >> + * location where this macro is referenced, to return to the calling function. >> * There's good reason for this. >> * >> * To use safely closures asynchronously, they must always have a refcount while >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
