Re: [PATCH] bcache: amend writeback_rate documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arne,

I looked at the latest code and the problem does not happen in our
development branch. For release kernels, a better fix might be to
actually change sysfs.c to read and write writeback_rate in units of
bytes. This way it is simpler to document. What do you think?

On Wed, Jun 18, 2014 at 3:13 AM, Arne Wiebalck <Arne.Wiebalck@xxxxxxx> wrote:
> From: Arne Wiebalck <Arne.Wiebalck@xxxxxxx>
>
> The writeback_rate is displayed in bytes per sec, but needs to
> be set in sectors per sec. This patch amends the documentation
> accordingly.
> ---
>  Documentation/bcache.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/bcache.txt b/Documentation/bcache.txt
> index 32b6c31..5643751 100644
> --- a/Documentation/bcache.txt
> +++ b/Documentation/bcache.txt
> @@ -268,9 +268,9 @@ writeback_percent
>    the rate.
>
>  writeback_rate
> -  Rate in sectors per second - if writeback_percent is nonzero, background
> +  Rate in bytes per second - if writeback_percent is nonzero, background
>    writeback is throttled to this rate. Continuously adjusted by bcache but may
> -  also be set by the user.
> +  also be set by the user (in sectors per second).
>
>  writeback_running
>    If off, writeback of dirty data will not take place at all. Dirty data will
> --
> 1.8.3.2.634.g7a3187e
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux