On Thu, 2014-02-06 at 10:00 +0100, Geert Uytterhoeven wrote: > On Mon, Feb 3, 2014 at 2:47 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Wed, Jan 15, 2014 at 12:06 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > >> On Wed, 2014-01-15 at 10:06 +0100, Geert Uytterhoeven wrote: > >>> drivers/md/bcache/btree.c: In function ‘insert_u64s_remaining’: > >>> drivers/md/bcache/btree.c:1816: warning: comparison of distinct pointer types lacks a cast > >> [] > >>> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > >> [] > >>> @@ -1813,7 +1813,7 @@ static size_t insert_u64s_remaining(struct btree *b) > >>> if (b->keys.ops->is_extents) > >>> ret -= KEY_MAX_U64S; > >>> > >>> - return max(ret, 0L); > >>> + return max_t(ssize_t, ret, 0L); > >> > >> why not > >> return max(ret, 0); > > > > Indeed, that also works, on both 32-bit and 64-bit. > > Will resend, now all the issues moved from -next to Linus' tree. > > However, sparse doesn't like it, so we'll have to go for v1? Seems so. -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
