On Mon, Oct 15, 2012 at 01:09:01PM -0700, Kent Overstreet wrote: > bio_integrity_split() seemed to be confusing pointers and arrays - > bip_vec in bio_integrity_payload was an array appended to the end of the > payload, so the bio_vecs in struct bio_pair should have come after the > bio_integrity_payload they're for. > > Fix it by making bip_vec a pointer to the inline vecs - a later patch is > going to make more use of this pointer. > > Signed-off-by: Kent Overstreet <koverstreet@xxxxxxxxxx> > CC: Jens Axboe <axboe@xxxxxxxxx> > CC: Martin K. Petersen <martin.petersen@xxxxxxxxxx> This being an apparent bug, I think it would be better to create a patch to simply reorder bio_pair fields to fix it and mark it w/ Cc: stable and introduce bip_vec pointer separately. Other than that, looks good. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
