On Tue, Aug 14, 2012 at 02:33:20PM +0900, Jun'ichi Nomura wrote: > On 08/07/12 07:08, Kent Overstreet wrote: > > struct dm_rq_clone_bio_info { > > struct bio *orig; > > struct dm_rq_target_io *tio; > > + struct bio clone; > > }; > ... > > - pools->bs = bioset_create(pool_size, 0); > > + pools->bs = bioset_create(pool_size, > > + offsetof(struct dm_rq_clone_bio_info, orig)); > > if (!pools->bs) > > goto free_tio_pool_and_out; > > Shouldn't this be offsetof(struct dm_rq_clone_bio_info, clone)? Ouch! Yes, it definitely should be. Good catch, and thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html