On Thu, May 24, 2012 at 07:56:03PM +0300, Boaz Harrosh wrote: [..] > In the split you have a single bio with or without bvects allocation > should you not let the caller make sure not to set __GFP_WAIT. > > For me, inspecting current->bio_list is out of context and a complete > hack. The caller should take care of it, which has more context. > > For example I might want to use split from OSD code where I do > not use an elevator at all, and current->bio_list could belong > to a completely different device. (Maybe) FWIW, I too think that checking for current->bio_list in bio_split() sounds hackish and it should be left to caller to set right gfp flags. And it should be commented well. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
