On Thu, May 24, 2012 at 03:42:52PM -0400, Vivek Goyal wrote: > On Wed, May 23, 2012 at 05:02:44PM -0700, Kent Overstreet wrote: > > [..] > > @@ -567,10 +569,13 @@ static struct packet_data *pkt_alloc_packet_data(int frames) > > goto no_pkt; > > > > pkt->frames = frames; > > - pkt->w_bio = pkt_bio_alloc(frames); > > + pkt->w_bio = bio_kmalloc(GFP_KERNEL, frames); > > So previously bios allocated were being kfreed by pkt_bio_destructor(). > Now where are we doing kfree() on bio being allocated by bio_kmalloc()? bio_kmalloc() sets up bi_destructor, so there's no need to kfree() the bio - bio_put() frees it just like normal. -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
