Re: [PATCH 04/13] OMAP2/3 clock: ensure each clock has a unique name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

On Mon, 17 Aug 2009, Tony Lindgren wrote:

> * Paul Walmsley <paul@xxxxxxxxx> [090815 14:26]:
> > After the clkdev conversion, struct clk .name fields are free to be
> > unique and to reflect the underlying hardware naming convention.  This
> > is important since it is useful for some core code that is unrelated
> > to the platform_device subsystem, such as the clock debugfs code and
> > the omap_hwmod code, to be able to address clocks by a single unique
> > identifier, since platform drivers are only weakly bound to clocks.
> > So, update all of the non-unique clock names in OMAP2/3 to be unique
> > names.  In the future it might be ideal to ensure that the names match
> > the hardware information exactly, for ease of debugging and reference.
> 
> Giving up on the name + id combination is against what we've tried to
> do with the clock framework in general.

This already happened with the clkdev conversion a few months ago.  At 
that point, device drivers address clocks with a clock alias string, e.g., 
"fck", plus a struct device pointer.  This patch doesn't change that.  

What it does remove is the need for internal core code to fake up a struct 
device simply to access a clock.  It also allows us to harmonize the 
clock names, used internally in core code, with the hardware reality, 
which uses unique names to identify clocks.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-arm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux