Re: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne torek, 07. december 2021 ob 21:26:50 CET je Doug Anderson napisal(a):
> Hi,
> 
> On Tue, Dec 7, 2021 at 12:03 PM Rob Clark <robdclark@xxxxxxxxx> wrote:
> > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> > 
> > Otherwise we don't get another shot at it if the bridge probes before
> > the dsi host is registered.  It seems like this is what *most* (but not
> > all) of the other bridges do.
> > 
> > It looks like this was missed in the conversion to attach dsi host at
> > probe time.
> > 
> > Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI
> > device at probe") Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> > ---
> > 
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3
> > 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86
> > *pdata)> 
> >         host = of_find_mipi_dsi_host_by_node(pdata->host_node);
> >         if (!host) {
> >         
> >                 DRM_ERROR("failed to find dsi host\n");
> > 
> > -               return -ENODEV;
> > +               return -EPROBE_DEFER;
> 
> Can you delete the DRM_ERROR line?

or use dev_err_probe()

Best regards,
Jernej






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux