On Wed, Dec 1, 2021 at 12:39 AM Petri Latvala <petri.latvala@xxxxxxxxx> wrote: > > On Mon, Nov 29, 2021 at 04:43:23PM -0800, Rob Clark wrote: > > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > Split the readN()/writeN() helpers out into an igt_io module, so they > > can be re-used by tests. > > > > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > > --- > > lib/igt_io.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++++ > > lib/igt_io.h | 33 +++++++++++++++++ > > lib/igt_sysfs.c | 45 +++-------------------- > > lib/meson.build | 1 + > > 4 files changed, 135 insertions(+), 40 deletions(-) > > create mode 100644 lib/igt_io.c > > create mode 100644 lib/igt_io.h > > > > diff --git a/lib/igt_io.c b/lib/igt_io.c > > new file mode 100644 > > index 00000000..ad54cbe5 > > --- /dev/null > > +++ b/lib/igt_io.c > > @@ -0,0 +1,96 @@ > > +/* > > + * Copyright © 2016 Intel Corporation > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a > > + * copy of this software and associated documentation files (the "Software"), > > + * to deal in the Software without restriction, including without limitation > > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > > + * and/or sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice (including the next > > + * paragraph) shall be included in all copies or substantial portions of the > > + * Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS > > + * IN THE SOFTWARE. > > + * > > + */ > > + > > +#include <errno.h> > > +#include <stdlib.h> > > +#include <unistd.h> > > + > > +#include "igt_io.h" > > + > > +/** > > + * SECTION:igt_io > > + * @short_description: Helpers for file I/O > > + * @title: io > > + * @include: igt_io.h > > + * > > + * This library provides helpers for file I/O > > + */ > > + > > This new section needs to be explicitly included in the docs. Squash this in: > > diff --git a/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml b/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml > index 189597c6..0dc5a0b7 100644 > --- a/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml > +++ b/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml > @@ -30,6 +30,7 @@ > <xi:include href="xml/igt_fb.xml"/> > <xi:include href="xml/igt_frame.xml"/> > <xi:include href="xml/igt_gt.xml"/> > + <xi:include href="xml/igt_io.xml"/> > <xi:include href="xml/igt_kmod.xml"/> > <xi:include href="xml/igt_kms.xml"/> > <xi:include href="xml/igt_list.xml"/> > > Oh, right.. I've squashed that in locally.. lmk if you want me to resend BR, -R > > -- > Petri Latvala
