On 01.12.2021 08:29, Vinod Koul wrote: > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Add device tree nodes for two i2c blocks: i2c13 and i2c14. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 64 ++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > [...] > config_noc: interconnect@1500000 { > compatible = "qcom,sm8450-config-noc"; > reg = <0 0x01500000 0 0x1c000>; > @@ -687,6 +725,32 @@ tlmm: pinctrl@f100000 { > gpio-ranges = <&tlmm 0 0 211>; > wakeup-parent = <&pdc>; > > + qup_i2c13_default_state: qup-i2c13-default-state { > + mux { > + pins = "gpio48", "gpio49"; > + function = "qup13"; > + }; > + > + config { > + pins = "gpio48", "gpio49"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + }; > + This should be collapsed into: qup_i2c13_default_state: qup-i2c13-default-state { pins = "..." function = "..." drive-strength = <2> bias-pull-up; }; And the same goes for the rest of the pins. [...] Konrad