On Wed, Dec 01, 2021 at 05:05:59AM +0300, Dmitry Baryshkov wrote:
> Change sdhcN aliases to mmcN to make them actually work. Currently the
> board uses non-standard aliases sdhcN, which do not work, resulting in
> mmc0 and mmc1 hosts randomly changing indices between boots.
>
> Fixes: c4da5a561627 ("arm64: dts: qcom: Add msm8916 sdhci configuration nodes")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
I've been meaning to fix this for quite some time, but whenever I tried
I wasn't actually able to reproduce the random numbering. They were
always numbered correctly but that was probably lucky coincidence. :)
Thanks for sending this!
Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index c1c42f26b61e..8be601275e9b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -19,8 +19,8 @@ / {
> #size-cells = <2>;
>
> aliases {
> - sdhc1 = &sdhc_1; /* SDC1 eMMC slot */
> - sdhc2 = &sdhc_2; /* SDC2 SD card slot */
> + mmc0 = &sdhc_1; /* SDC1 eMMC slot */
> + mmc1 = &sdhc_2; /* SDC2 SD card slot */
> };
>
> chosen { };
> --
> 2.33.0
>
