Re: [PATCH v2 1/2] drm/msm: Allocate msm_drm_private early and pass it as driver data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi AngeloGioacchino,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on next-20211130]
[cannot apply to v5.16-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/AngeloGioacchino-Del-Regno/drm-msm-Fix-dsi-bridge-probe/20211130-221304
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: csky-randconfig-c004-20211128 (https://download.01.org/0day-ci/archive/20211201/202112011405.Wn79h7q3-lkp@xxxxxxxxx/config)
compiler: csky-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/msm/msm_drv.c:412:1-6: WARNING: invalid free of devm_ allocated data

vim +412 drivers/gpu/drm/msm/msm_drv.c

2aa31767259722 Sean Paul           2019-05-24  384  
98659487b845c0 Abhinav Kumar       2021-04-16  385  	msm_disp_snapshot_destroy(ddev);
98659487b845c0 Abhinav Kumar       2021-04-16  386  
2b669875332fbd Archit Taneja       2016-05-02  387  	drm_mode_config_cleanup(ddev);
c8afe684c95cd1 Rob Clark           2013-06-26  388  
2b669875332fbd Archit Taneja       2016-05-02  389  	pm_runtime_get_sync(dev);
f026e431cf8611 Thomas Zimmermann   2021-08-03  390  	msm_irq_uninstall(ddev);
2b669875332fbd Archit Taneja       2016-05-02  391  	pm_runtime_put_sync(dev);
c8afe684c95cd1 Rob Clark           2013-06-26  392  
16976085a114ae Archit Taneja       2016-11-03  393  	if (kms && kms->funcs)
c8afe684c95cd1 Rob Clark           2013-06-26  394  		kms->funcs->destroy(kms);
c8afe684c95cd1 Rob Clark           2013-06-26  395  
871d812aa43e63 Rob Clark           2013-11-16  396  	if (priv->vram.paddr) {
00085f1efa387a Krzysztof Kozlowski 2016-08-03  397  		unsigned long attrs = DMA_ATTR_NO_KERNEL_MAPPING;
871d812aa43e63 Rob Clark           2013-11-16  398  		drm_mm_takedown(&priv->vram.mm);
2b669875332fbd Archit Taneja       2016-05-02  399  		dma_free_attrs(dev, priv->vram.size, NULL,
00085f1efa387a Krzysztof Kozlowski 2016-08-03  400  			       priv->vram.paddr, attrs);
871d812aa43e63 Rob Clark           2013-11-16  401  	}
871d812aa43e63 Rob Clark           2013-11-16  402  
2b669875332fbd Archit Taneja       2016-05-02  403  	component_unbind_all(dev, ddev);
060530f1ea6740 Rob Clark           2014-03-03  404  
bc3220be22577e Rajesh Yadav        2018-06-21  405  	if (mdss && mdss->funcs)
bc3220be22577e Rajesh Yadav        2018-06-21  406  		mdss->funcs->destroy(ddev);
0a6030d224d3a4 Archit Taneja       2016-05-08  407  
2b669875332fbd Archit Taneja       2016-05-02  408  	ddev->dev_private = NULL;
4d8dc2dfae2c48 Thomas Zimmermann   2018-09-26  409  	drm_dev_put(ddev);
c8afe684c95cd1 Rob Clark           2013-06-26  410  
2aa31767259722 Sean Paul           2019-05-24  411  	destroy_workqueue(priv->wq);
c8afe684c95cd1 Rob Clark           2013-06-26 @412  	kfree(priv);
c8afe684c95cd1 Rob Clark           2013-06-26  413  
c8afe684c95cd1 Rob Clark           2013-06-26  414  	return 0;
c8afe684c95cd1 Rob Clark           2013-06-26  415  }
c8afe684c95cd1 Rob Clark           2013-06-26  416  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux