Hello! [...] > > > Not really a requirement to do so, but you could include the actual > > > warning, as sometimes this is useful for reference later, as per: > > > > > > drivers/pci/controller/dwc/pcie-qcom.c:1346:30: warning: incorrect type in initializer (different base types) > > > drivers/pci/controller/dwc/pcie-qcom.c:1346:30: expected unsigned short [usertype] bdf_be > > > drivers/pci/controller/dwc/pcie-qcom.c:1346:30: got restricted __be16 [usertype] > > > > > > > I usually do but as per Bjorn's comment I thought it is not recommended for PCI > > subsystem (or maybe I misread his comments). Will add. > > Ah right. I must have missed his comment too. I usually include warnings > myself, where applicable. Let's wait for what Bjorn says, just in case, so > that we avoid adding something he does not want to have included in the > commit message. Ah! I see a v3. You act fast. :) Krzysztof
