On Mon, Nov 22, 2021 at 12:11:35PM +0100, Thomas Perrot wrote:
> Add support for EM919X modems, this modem series is based on SDX55
> qcom chip.
>
> Tested-by: Aleksander Morgado <aleksander@xxxxxxxxxxxxx>
> Signed-off-by: Thomas Perrot <thomas.perrot@xxxxxxxxxxx>
> ---
> drivers/bus/mhi/pci_generic.c | 43 +++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 59a4896a8030..076a951fd587 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -403,7 +403,50 @@ static const struct mhi_pci_dev_info mhi_mv31_info = {
> .dma_data_width = 32,
> };
>
> +static const struct mhi_channel_config mhi_sierra_em919x_channels[] = {
> + MHI_CHANNEL_CONFIG_UL_SBL(2, "SAHARA", 32, 0),
> + MHI_CHANNEL_CONFIG_DL_SBL(3, "SAHARA", 256, 0),
> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 0),
DIAG generally uses a dedicated event ring.
> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 128, 0),
> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 128, 0),
> + MHI_CHANNEL_CONFIG_UL(14, "QMI", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(15, "QMI", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0", 512, 1),
> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0", 512, 2),
> +};
> +
> +static struct mhi_event_config modem_sierra_em919x_mhi_events[] = {
> + /* first ring is control+data and DIAG ring */
> + MHI_EVENT_CONFIG_CTRL(0, 2048),
I think you can just split control+data and diag events as like other modems.
If there is a requirement, please mention in commit description.
Rest LGTM.
Thanks,
Mani
