Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
From: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
Date: Tue, 16 Nov 2021 11:56:37 +0000
Cc: phone-devel@xxxxxxxxxxxxxxx, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Jingoo Han <jingoohan1@xxxxxxxxx>, ~postmarketos/upstreaming@xxxxxxxxxxx, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>, Martin Botka <martin.botka@xxxxxxxxxxxxxx>, Jami Kettunen <jami.kettunen@xxxxxxxxxxxxxx>, Pavel Dubrova <pashadubrova@xxxxxxxxx>, Kiran Gunda <kgunda@xxxxxxxxxxxxxx>, Bryan Wu <cooloney@xxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx
In-reply-to: <20211115203459.1634079-4-marijn.suijten@somainline.org>
References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211115203459.1634079-4-marijn.suijten@somainline.org>

On Mon, Nov 15, 2021 at 09:34:53PM +0100, Marijn Suijten wrote:
> The kernel already provides appropriate primitives to perform endianness
> conversion which should be used in favour of manual bit-wrangling.
> 
> Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>


Daniel.

References:
- [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings
  - From: Marijn Suijten
- [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
  - From: Marijn Suijten

Prev by Date: [PATCH v3 3/3] arm64: dts: qcom: Fix 'interrupt-map' parent address cells
Next by Date: Re: [PATCH v3 4/9] backlight: qcom-wled: Fix off-by-one maximum with default num_strings
Previous by thread: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
Next by thread: Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]