Quoting Rakesh Pillai (2021-11-02 06:44:33) > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c > index 098362e6..e2e8d33 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -435,12 +571,22 @@ static int adsp_probe(struct platform_device *pdev) > if (!desc) > return -EINVAL; > > + firmware_name = desc->firmware_name; > + ret = of_property_read_string(pdev->dev.of_node, "firmware-name", Is this documented in the binding? If not, please add it. > + &firmware_name); > + if (ret < 0 && ret != -EINVAL) { > + dev_err(&pdev->dev, "unable to read firmware-name\n"); > + return ret; > + } > + > rproc = rproc_alloc(&pdev->dev, pdev->name, &adsp_ops, > - desc->firmware_name, sizeof(*adsp)); > + firmware_name, sizeof(*adsp)); > if (!rproc) {