On Wed, Nov 10, 2021 at 01:44:20PM -0600, Rob Herring wrote: > On Wed, 10 Nov 2021 20:07:15 +0800, Shawn Guo wrote: > > Add bindings for Qualcomm QCM2290 Network-On-Chip interconnect devices. > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > --- > > .../bindings/interconnect/qcom,qcm2290.yaml | 117 ++++++++++++++++++ > > .../dt-bindings/interconnect/qcom,qcm2290.h | 94 ++++++++++++++ > > 2 files changed, 211 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml > > create mode 100644 include/dt-bindings/interconnect/qcom,qcm2290.h > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/interconnect/qcom,qcm2290.example.dts:20:18: fatal error: dt-bindings/clock/qcom,gcc-qcm2290.h: No such file or directory > 20 | #include <dt-bindings/clock/qcom,gcc-qcm2290.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thanks for the report! The header has just landed on mainline tree. But the binding actually doesn't need to include it. I will drop it for the next posting. Shawn