At 2021-10-29 18:25:26, "Manivannan Sadhasivam" <mani@xxxxxxxxxx> wrote: >On Fri, Oct 29, 2021 at 06:00:42PM +0800, Slark Xiao wrote: >> >> At 2021-10-29 17:26:19, "Manivannan Sadhasivam" <mani@xxxxxxxxxx> wrote: >> >> >Hi, >> > >> >On Thu, Oct 28, 2021 at 11:44:31AM +0800, Slark Xiao wrote: >> >> Add new device ID 0xe0bf for T99W175. >> >> >> > >> >Thanks for the patch! Can you share the difference between this modem and the >> >one (T99W175) we already have with PID 0xe0ab? >> > >> >Please include the product page in description if any. >> > >> >Thanks, >> >Mani >> > >> Hi Mani, >> Thanks for this review. >> Actually this product(SDX55/0xe0bf) is using Qualcomm SDX55 new baseline(LE1.4), >> and previous T99W175/0xe0ab is using original base line(LE1.2). >> Our customer wants us to use different device ID to separate from each other. >> Currently we don't have product page as our customer's new product is not released. >> > >Thanks for the explanation. Please send v2 adding the baseline info in commit >description. > >Thanks, >Mani > Hi Mani, I have sent V2 several days ago . Please take a look on that. Ref link: https://lore.kernel.org/lkml/20211029104918.3976-1-slark_xiao@xxxxxxx/ Thanks! Slark >> >> Test evidence as below: >> >> root@jbd-ThinkPad-P1-Gen-4:/dev# lspci -nn | grep Foxconn >> >> 0000:08:00.0 Wireless controller [0d40]: Foxconn International, Inc. Device [105b:e0bf] >> >> root@jbd-ThinkPad-P1-Gen-4:/dev# cat wwan0at0 & echo -ne "ati\r" > wwan0at0 >> >> [2] 2977 >> >> root@jbd-ThinkPad-P1-Gen-4:/dev# ati >> >> Manufacturer: Qualcomm >> >> Model: T99W175 >> >> Revision: T99W175.F0.6.0.0.6.CC.005 1 [Oct 21 2021 10:00:00] >> >> IMEI: >> >> +GCAP: +CGSM >> >> >> >> OK >> >> >> >> Signed-off-by: Slark Xiao <slark_xiao@xxxxxxx> >> >> --- >> >> drivers/bus/mhi/pci_generic.c | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c >> >> index 59a4896a8030..566483dc15db 100644 >> >> --- a/drivers/bus/mhi/pci_generic.c >> >> +++ b/drivers/bus/mhi/pci_generic.c >> >> @@ -423,6 +423,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { >> >> /* DW5930e (sdx55), Non-eSIM, It's also T99W175 */ >> >> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0b1), >> >> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info }, >> >> + /* T99W175 (sdx55) */ >> >> + { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0bf), >> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info }, >> >> /* MV31-W (Cinterion) */ >> >> { PCI_DEVICE(0x1269, 0x00b3), >> >> .driver_data = (kernel_ulong_t) &mhi_mv31_info }, >> >> -- >> >> 2.25.1 >> >>
