On Thu, Oct 28, 2021 at 8:32 AM Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > > V2: > > Guenter Roeck's review > - Converts suggested qcom_pmic_tcpm_core.c into one-liners > > - Adds comment on how polarity is set in set_polarity() > > - Removes optional set_current_limit() > > - regmap_read/regmap_write > Reviwing other pm8150b/spmi drivers I then added in checks for all > reamap_read()/regmap_write() calls. > > - Fixes (type == TCPC_TX_CABLE_RESET || TCPC_TX_HARD_RESET) > thanks I definitely had the blinkers on there and didn't see that at all > > - qcom_pmic_tcpm_pdphy_pd_transmit_payload() > Treats regmap_read and read value as separate error paths > > - qcom_pmic_tcpm_pdphy_set_pd_rx() > Replaces boolean if/else with !on as suggested > > - Returns -ENODEV not -EINVAL on dev_get_regmap() error > > - qcom_pmic_tcpm_pdphy_pd_receive() > Guenter asks: "No error return ?" > bod: No we are inside an ISR here if we read data we pass that off to TCPM > if somehow we don't read the data - it is "junk" there's no value IMO > in pushing an error upwards back to the handler. > > Heikki Krogerus' review > - Includes Makefile I missed adding to my git index > > - Removes old Kconfig entry for remove driver > > Randy Dunlap's review > - Rewords drivers/usb/typec/tcpm/Kconfig > > - Drops tautology "aggregates togther" > > - Corrects spelling typos > > BOD's own review > - Drops redundant include of regmap.h in qcom_pmic_tcpm_core.c > > - Propogates qcom_pmic_tcpm_pdphy_disable() error upwards > > - Propogates pmic_pdphy_reset() error upwards > > - Drops error prints in qcom_pmic_tcpm_pdphy_pd_transmit_payload() > I had these in-place during development and don't recall them being > triggered even once, they are redundant, remove. > > Differences between the two can be seen by > git diff usb-next-27-10-21-pm8150b-tcpm-v2..usb-next-25-10-21-pm8150b-tcpm -- drivers/usb/typec/tcpm > > Latest bootable series can be found here: > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=usb-next-27-10-21-pm8150b-tcpm-v2 > > Previous set: > Link: https://lore.kernel.org/all/20211025150906.176686-1-bryan.odonoghue@xxxxxxxxxx/T/#t > > V1: > This series adds a set of yaml and a driver to bind together the type-c and > pdphy silicon in qcom's pm8150b block as a Linux type-c port manager. > > As part of that we retire the existing qcom-pmic-typec driver and fully > replicate its functionality inside of the new block with the additional > pdphy stuff along with it. > > An additional series will follow this one for the SoC and RB5 dtsi and dts > respectively. > > A bootable series can be found here > > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=usb-next-25-10-21-pm8150b-tcpm > > Bryan O'Donoghue (7): > dt-bindings: usb: Add qcom,pmic-usb-typec dt-binding header > dt-bindings: usb: Add Qualcomm PMIC type C controller YAML schema > dt-bindings: usb: Add qcom,pmic-usb-pdphy dt-binding header > dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema > dt-bindings: usb: Add Qualcomm PMIC TCPM YAML schema Send to DT list please. > usb: typec: qcom: Remove standalone qcom pm8150b typec driver > usb: typec: qcom: Add a pm8150b TCPM driver
