Hi, On Sat, Oct 23, 2021 at 8:54 PM Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > > On Mon 18 Oct 16:45 CDT 2021, Doug Anderson wrote: > > > Bjorn, > > > > On Wed, Sep 29, 2021 at 9:00 PM <skakit@xxxxxxxxxxxxxx> wrote: > > > > > > On 2021-09-30 04:08, Douglas Anderson wrote: > > > > The RTC on the pmk8350 is not useful on all boards. Some boards may > > > > not provide backup power to the PMIC but might have another RTC on the > > > > board that does have backup power. In this case it's better to not use > > > > the RTC on the PMIC. > > > > > > > > At the moment, the only boards that includes this PMIC are sc7280-idp > > > > and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but > > > > sc7280-idp2 has a Chrome OS EC on it and this is intended to provide > > > > the RTC for the AP. > > > > > > > > Let's do what we normally do for hardware that's not used by all > > > > boards and set it to a default status of "disabled" and then enable it > > > > on the boards that need it. > > > > > > > > NOTE: for sc7280-idp it's _possible_ we might also want to add > > > > `allow-set-time;`. That could be the subject of a future patch if it > > > > is indeed true. > > > > > > > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > > > --- > > > > > > > > > > Reviewed-by: Satya Priya <skakit@xxxxxxxxxxxxxx> > > > > If you're still accepting patches for 5.16, it'd be keen if you'd > > consider taking this one. Thanks! > > > > I've picked the patch and hope to get it included in v5.16. > > I do however not understand why the commit message so clearly defines > that the only device including pmk8350 is the sc7280 idp when the > sm8350-mtp.dts contains the following line: > > #include "pmk8350.dtsi" > > > Perhaps I'm missing something obvious, but I took the liberty of also > enabling the RTC in the SM8350 MTP. Thank you for fixing this up. I must have just glazed over that part of things. :( Glad you caught and fixed it. -Doug
