On Tue 19 Oct 13:43 PDT 2021, Arnd Bergmann wrote:
> On Thu, Sep 23, 2021 at 2:18 PM Rajesh Patil <rajpat@xxxxxxxxxxxxxx> wrote:
> >
> > Add aliases for i2c and spi for sc7280 soc.
> >
> > Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx>
> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
> I saw this in the pull request, can this please be reverted?
>
Yes, this can certainly be corrected.
> Putting the aliases into the .dtsi file is really silly, as there are
> likely boards that
> don't connect every single one of those, and then will have to
> override and renumber
> them.
>
> Please only list the aliases that are actually connected on a particular
> board.
>
> Arnd
>
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index c26647a..e5fefd1 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -26,8 +26,40 @@
> > chosen { };
> >
> > aliases {
> > + i2c0 = &i2c0;
> > + i2c1 = &i2c1;
> > + i2c2 = &i2c2;
> > + i2c3 = &i2c3;
> > + i2c4 = &i2c4;
> > + i2c5 = &i2c5;
> > + i2c6 = &i2c6;
> > + i2c7 = &i2c7;
> > + i2c8 = &i2c8;
> > + i2c9 = &i2c9;
> > + i2c10 = &i2c10;
> > + i2c11 = &i2c11;
> > + i2c12 = &i2c12;
> > + i2c13 = &i2c13;
> > + i2c14 = &i2c14;
> > + i2c15 = &i2c15;
> > mmc1 = &sdhc_1;
> > mmc2 = &sdhc_2;
>
> The mmc ones should probably go away as well.
>
I should have paid more attention when applying this patch, because the
commit message should have stated why any of these were introduced.
@Rajesh, can you please help me understand the need for any of these and
prepare a patch that introduce the specific ones needed in the
individual board dts(i) files - with reasoning for the aliases in the
commit message.
Thanks,
Bjorn
> > + spi0 = &spi0;
> > + spi1 = &spi1;
> > + spi2 = &spi2;
> > + spi3 = &spi3;
> > + spi4 = &spi4;
> > + spi5 = &spi5;
> > + spi6 = &spi6;
> > + spi7 = &spi7;
> > + spi8 = &spi8;
> > + spi9 = &spi9;
> > + spi10 = &spi10;
> > + spi11 = &spi11;
> > + spi12 = &spi12;
> > + spi13 = &spi13;
> > + spi14 = &spi14;
> > + spi15 = &spi15;
> > };
> >
