On Sat, 2021-10-16 at 09:37 +0200, Greg KH wrote: > On Sat, Oct 16, 2021 at 12:27:34PM +0530, Manivannan Sadhasivam wrote: > > From: Qing Wang <wangqing@xxxxxxxx> > > coccicheck complains about the use of snprintf() in sysfs show functions. [] > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c [] > > @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev, > > struct mhi_device *mhi_dev = to_mhi_device(dev); > > struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; > > > > - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n", > > + return sysfs_emit(buf, "Serial Number: %u\n", > > mhi_cntrl->serial_number); > > The text "Serial Number: " should not be in here, right? It's obvious > this is a serial number, that's what the documentation and file name > says. Userspace should not have to parse sysfs files. sysfs is ABI right? Parsing or not, it's what's already there.
