Hi Dmitry, On Fri, Oct 15, 2021 at 2:26 AM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > On 13/10/2021 17:42, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > When CONFIG_COMMON_CLOCK is disabled, the 8996 specific > > phy code is left out, which results in a link failure: > > > > ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' > > > > This was only exposed after it became possible to build > > test the driver without the clock interfaces. > > > > Make COMMON_CLK a hard dependency for compile testing, > > and simplify it a little based on that. > > > > Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > This drops dependency on CONFIG_OF. While ARM64 selects OF, pure ARM > does not. But SOC_IMX5 depends on ARCH_MULTI_V7, which depends on ARCH_MULTIPLATFORM, which selects USE_OF, which selects OF. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds