On 02-08-21, 17:24, abhinavk@xxxxxxxxxxxxxx wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > We cannot enable mode_3d when we are using the DSC. So pass > > configuration to detect DSC is enabled and not enable mode_3d > > when we are using DSC > > > > We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc > > enabled and pass this to .setup_intf_cfg() > > > This is not entirely correct. This is true only for the 2-2-1 topology you > are using > on this panel. > > When you are using 2-2-1, you are using 2 LMs, 2 DSCs and 1 DSI. > So 3D mux shouldnt be used. > > If you are using something like 4-2-1 or 4-2-2, then you have 4LMs, > 2 DSCs and 2/1 DSI. > > Here you need the 3D mux to convert the data from 4LMs to 2 DSCs. > > So please correct the commit text here and also add a check for the > topology. Ack, we should mention this and modify it in future when more topology support is added. -- ~Vinod
