On Sun, 26 Sep 2021, Dmitry Baryshkov wrote:
> PM8xxx PMIC family uses GPIO as parent IRQ. Using it together with the
> irq_set_chained_handler_and_data() results in warnings from the GPIOLIB
> (see 461c1a7d4733 ("gpiolib: override irq_enable/disable"))
> as in this path the IRQ resources are not allocated (and thus the
> corresponding GPIO is not marked as used for the IRQ. Use request_irq so
> that the IRQ resources are proprely setup.
[...]
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Tested-by: David Heidelberg <david@xxxxxxx>
> ---
> Changes since v1:
> - Expanded commit message to include warning text and gpiolib details
> - No code changes
Replaced the previous applied version with this one, thanks.
> ---
> drivers/mfd/qcom-pm8xxx.c | 39 ++++++++++++++++-----------------------
> 1 file changed, 16 insertions(+), 23 deletions(-)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
