Hei hei, Am Wed, Sep 08, 2021 at 03:39:51AM +0000 schrieb Stephen Boyd: > Quoting Bjorn Andersson (2021-06-22 20:50:38) > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > > new file mode 100644 > > index 000000000000..10aee61a7ffc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > > @@ -0,0 +1,164 @@ > [....] > > +examples: > > + - | > > + #include <dt-bindings/leds/common.h> > > + > > + lpg { > > Should the node name be led or leds? If I scan through Documentation/devicetree/bindings/leds and look at other devices, it should probably be named "led-controller", right? At least that's what Rob suggested when I converted the leds-pwm binding last year, using generic node names: https://lore.kernel.org/linux-leds/20200922155747.GA2734659@bogus/ Greets Alex > > > + compatible = "qcom,pmi8994-lpg"; > > Shouldn't there be a reg property? I see the driver has them hardcoded > but if this is a child of the spmi node then it should have a reg > property (or many reg properties).