On 03.10.2021 10:31, Luca Weiss wrote:
> Add device tree for the Fairphone 4 smartphone which is based on
> Snapdragon 750G (sm7225) which is basically sm6350.
>
> Currently supported are UART, physical buttons (power & volume), screen
> (based on simple-framebuffer set up by the bootloader), regulators and
> USB.
>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
> [...]
> +
> +&pm6350_gpios {
> + gpio_keys_pins: gpio-keys-pins {
'pin' singular, I guess
> + pinconf {
> + pins = "gpio2";
> + function = PMIC_GPIO_FUNC_NORMAL;
> + bias-pull-up;
> + input-enable;
> + power-source = <0>;
> + };
pinconf {} is not necessary
[...]
Other than that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
Konrad
