Hey Dan, Thanks for the report, will take care of it. On 2021-10-01 05:31, Dan Carpenter wrote:
Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2018, leads to the following Smatch static checker warning: drivers/gpu/drm/msm/dsi/dsi_host.c:729 dsi_calc_clk_rate_6g() warn: wrong type for 'msm_host->esc_clk_rate' (should be 'ulong') drivers/gpu/drm/msm/dsi/dsi_host.c 721 int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi) 722 { 723 if (!msm_host->mode) { 724 pr_err("%s: mode not set\n", __func__); 725 return -EINVAL; 726 } 727 728 dsi_calc_pclk(msm_host, is_bonded_dsi);--> 729 msm_host->esc_clk_rate = clk_get_rate(msm_host->esc_clk);^^^^^^^^^^^^^^^^^^^^^^ I don't know why Smatch is suddenly warning about ancient msm code, but clock rates should be unsigned long. (I don't remember why). 730 return 0; 731 } regards, dan carpenter
Thanks, Jessica Zhang
