On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > BTW, change the return value from 'ENXIO' to 'ENODEV', > perfer ENODEV which means no such device. > > Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx> > --- > v2->v3: Update the changelog. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij