Hello, >-----Original Message----- >From: nguyenb=codeaurora.org@xxxxxxxxxxxxxxxxx >[mailto:nguyenb=codeaurora.org@xxxxxxxxxxxxxxxxx] On Behalf Of Bao D. >Nguyen >Sent: Tuesday, September 21, 2021 2:38 AM >To: cang@xxxxxxxxxxxxxx; asutoshd@xxxxxxxxxxxxxx; >martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx >Cc: linux-arm-msm@xxxxxxxxxxxxxxx; Bao D . Nguyen ><nguyenb@xxxxxxxxxxxxxx>; Andy Gross <agross@xxxxxxxxxx>; Bjorn Andersson ><bjorn.andersson@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri >Altman <avri.altman@xxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxx>; >open list <linux-kernel@xxxxxxxxxxxxxxx> >Subject: [PATCH v1 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling > >From: Asutosh Das <asutoshd@xxxxxxxxxxxxxx> > >Qualcomm controller needs to be in hibern8 before scaling clocks. >This change puts the controller in hibern8 state before scaling and brings it out >after scaling of clocks. > >Signed-off-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx> >Signed-off-by: Bao D. Nguyen <nguyenb@xxxxxxxxxxxxxx> >--- Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > drivers/scsi/ufs/ufs-qcom.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index >92d4c61..92f5bb4 100644 >--- a/drivers/scsi/ufs/ufs-qcom.c >+++ b/drivers/scsi/ufs/ufs-qcom.c >@@ -1212,24 +1212,34 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba >*hba, > int err = 0; > > if (status == PRE_CHANGE) { >+ err = ufshcd_uic_hibern8_enter(hba); >+ if (err) >+ return err; > if (scale_up) > err = ufs_qcom_clk_scale_up_pre_change(hba); > else > err = ufs_qcom_clk_scale_down_pre_change(hba); >+ if (err) >+ ufshcd_uic_hibern8_exit(hba); >+ > } else { > if (scale_up) > err = ufs_qcom_clk_scale_up_post_change(hba); > else > err = ufs_qcom_clk_scale_down_post_change(hba); > >- if (err || !dev_req_params) >+ >+ if (err || !dev_req_params) { >+ ufshcd_uic_hibern8_exit(hba); > goto out; >+ } > > ufs_qcom_cfg_timers(hba, > dev_req_params->gear_rx, > dev_req_params->pwr_rx, > dev_req_params->hs_rate, > false); >+ ufshcd_uic_hibern8_exit(hba); > } > > out: >-- >The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a >Linux Foundation Collaborative Project
