Re: [PATCH] mfd: qcom-pm8xxx: switch away from using chained IRQ handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



with this patch, it does boot without any problems or warnings regarding to IRQ.

Tested-by: David Heidelberg <david@xxxxxxx>
Best regards
David Heidelberg

On Thu, Sep 23 2021 at 02:04:10 +0200, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
On Tue, Sep 21, 2021 at 6:24 PM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:

PM8xxx PMIC family uses GPIO as parent IRQ. Using it together with the irq_set_chained_handler_and_data() results in warnings from the GPIOLIB
 as in this path the IRQ resources are not allocated (and thus the
corresponding GPIO is not marked as used for the IRQ. Use request_irq so
 that the IRQ resources are proprely setup.

 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

I sent this patch:
https://lore.kernel.org/lkml/20210819154400.51932-1-linus.walleij@xxxxxxxxxx/

David Heidelberg reported that it didn't work for him.

David can you test Dmitry's patch instead and see if that works
for you, I suppose I could have some bug in my patch :/
It would be nice with a Tested-by from David.

FWIW the code looks good:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux