Hi, On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@xxxxxxxxxxxxxx> wrote: > > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx> > --- > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > index ef5698f..31711fe 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > @@ -21,7 +21,10 @@ allOf: > properties: > compatible: > items: > - - const: qcom,sdm845-qspi > + - enum: > + - qcom,sdm845-qspi > + - qcom,sc7280-qspi Other than the fact that the indentation is wrong (as Rob's bot found), this looks good to me. Feel free to add my Reviewed-by when you fix the indentation. In theory you could also be nice and add the sc7180-qspi at the same time, I think. -Doug