Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, September 15th, 2021 at 9:30 PM, Steev Klimaszewski <steev@xxxxxxxx> wrote:

> On 9/6/21 1:53 AM, Dan Carpenter wrote:
>
> > On Fri, Sep 03, 2021 at 07:29:28PM +0000, Yassine Oudjana wrote:
> >
> > > > if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
> > > >
> > > > @@ -506,8 +506,12 @@ int qrtr_endpoint_post(struct qrtr_endpoint
> > > >
> > > > *ep, const void *data, size_t len)
> > > >
> > > > if (cb->type == QRTR_TYPE_NEW_SERVER) {
> > > >
> > > > /* Remote node endpoint can bridge other distant nodes */
> > > >
> > > > -   const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
> > > >
> > > > -   const struct qrtr_ctrl_pkt *pkt;
> > > >
> > > > -   if (size < sizeof(*pkt))
> > > >
> > > > -   goto err;
> > > >
> > > >
> > > > -   pkt = data + hdrlen;
> > > >
> > > >     qrtr_node_assign(node, le32_to_cpu(pkt->server.node));
> > > >
> > > >     }
> > > >
> > > >
> > > > --
> > > >
> > > > 2.20.1
> > >
> > > This is crashing MSM8996. I get these messages (dmesg | grep
> > >
> > > remoteproc):
> > >
> > > Yes. I apologize for that. The fix has been merged already.
> >
> > regards,
> >
> > dan carpenter
>
> Where has the fix been merged to?  5.14.4 released with this patch in
>
> it, and wifi is now crashing on the Lenovo Yoga C630 with the same
>
> messages that Yassine was seeing.

The fix is in master[1]. You need to cherry-pick it.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d2cabd2dc8da78faf9b690ea521d03776686c9fe




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux