Hi Krzysztof,
On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote:
> On 12/09/2021 01:27, Luca Weiss wrote:
> > LG Electronics is a part of the LG Corporation and produces, amongst
> > other things, consumer electronics such as phones and smartwatches.
>
> Hi,
>
> Thanks for the patches.
>
> I think "lge" it's the same prefix as "lg". There is no sense in having
> multiple vendor prefixes just because company splits inside business
> units or subsidiaries. The same as with other conglomerates, e.g.
> Samsung - if we wanted to be specific, there will be 4-5 Samsung
> vendors... Not mentioning that company organisation is not always
> disclosed and can change.
>
I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the other LG
device tree I am aware of so I've picked lge instead of lg. Also worth noting
that Google uses "LGE" in the Android device tree[1] or in the model name in
the LG G Watch R kernel sources ("LGE APQ 8026v2 LENOK rev-1.0").
I don't have a strong opinion either way so I'm fine with either.
If we decide to go with "lg" do we want to change the Nexus 5 devicetree
(hammerhead) also, that one has the lge name in at least compatible and
filename (I don't know how much of a breaking change that would be considered
as).
> We already have lg for several components, also made by LG Electronics.
> What about these?
>
> There is only one device with "lge", added back in 2016 without adding
> vendor prefix. I would propose to fix that one, instead of keeping
> duplicated "lg".
>
> Best regards,
> Krzysztof
Regards
Luca
[1] https://android.googlesource.com/device/lge/hammerhead/
