On Thu, Sep 09, 2021 at 10:16:04AM +0530, rajpat@xxxxxxxxxxxxxx wrote: > On 2021-09-03 22:03, Matthias Kaehlcke wrote: > > On Fri, Sep 03, 2021 at 09:58:56AM +0530, Rajesh Patil wrote: > > > From: Roja Rani Yarubandi <rojay@xxxxxxxxxxxxxx> > > > > > > Add QUPv3 wrapper_0 DT nodes for SC7280 SoC. > > > > > > Signed-off-by: Roja Rani Yarubandi <rojay@xxxxxxxxxxxxxx> > > > Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx> > > > --- > > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 684 > > > ++++++++++++++++++++++++++++++++++- > > > 1 file changed, 682 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > index 7ec9871..5c6a1d7 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > > > > ... > > > > > > + qup_spi0_data_clk: qup-spi0-data-clk { > > > + pins = "gpio0", "gpio1", "gpio2"; > > > + function = "qup00"; > > > + }; > > > + > > > + qup_spi0_cs: qup-spi0-cs { > > > + pins = "gpio3"; > > > + function = "qup00"; > > > + }; > > > > > > I think we still want this for all SPI ports, which existed in previous > > versions: > > > > qup_spi0_cs_gpio: qup-spi0-cs-gpio { > > pins = "gpio3"; > > function = "gpio"; > > }; > > > > It just shouldn't be selected together with 'qup_spiN_cs'. > > > > Maybe a follow up patch would be good enough, so: > > > > Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > > ok.shall we add qup_spiN_cs_gpio for all spi ports Yes