Quoting Abhishek Kumar (2021-09-08 15:37:07) > > Overall this change should fix the issue, additionally I have one > comment below and would like other reviewers views. > > > #include <linux/regulator/consumer.h> > > +#include <linux/remoteproc/qcom_rproc.h> > > #include <linux/of_address.h> > We are adding an external dependency here but since this is added in > snoc.c (which is for integrated solution only), I can expect if SNOC > is enabled, remote proc will be enabled as well, so it should be fine. There are stubs so that if it isn't enabled it won't do anything. But as you say SNOC relies on the modem to boot, so maybe CONFIG_ATH10K_SNOC should depend on some remoteproc config anyway? I'm not clear how probe ordering works but I think we'll want to make sure that we only register the notifier once the remoteproc driver for the modem adds itself to the list of available strings to look for.
