Quoting Bjorn Andersson (2021-08-10 17:18:02) > On Tue 10 Aug 18:31 CDT 2021, Stephen Boyd wrote: > > > Quoting Mike Tipton (2021-07-21 10:54:32) > > > We're only adding BCMs to the commit list in aggregate(), but there are > > > cases where pre_aggregate() is called without subsequently calling > > > aggregate(). In particular, in icc_sync_state() when a node with initial > > > BW has zero requests. Since BCMs aren't added to the commit list in > > > these cases, we don't actually send the zero BW request to HW. So the > > > resources remain on unnecessarily. > > > > > > Add BCMs to the commit list in pre_aggregate() instead, which is always > > > called even when there are no requests. > > > > > > Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support") > > > Signed-off-by: Mike Tipton <mdtipton@xxxxxxxxxxxxxx> > > > --- > > > > This patch breaks reboot for me on sc7180 Lazor > > > > FWIW, it prevents at least SM8150 from booting (need to check my other > boards as well), because its no longer okay to have the interconnect > providers defined without having all client paths specified. So maybe the best course of action is to revert this patch from Linus' tree? It's not a super huge deal as "can't boot", but certainly makes reboot annoying on sc7180.