On 09-08-21, 16:38, Rajendra Nayak wrote: > Sure, I can do that, apart from the error print, the function currently also > returns a -EINVAL in case of the missing 'required-opps', are we suggesting > we change that to not return an error also? No. > Since this is completely optional in the device node, we would want the function to > ideally not return error and only do so in case 'required-opps' exists and the > translation to performance state fails. Not really. The function should return failure if the property isn't there, but it shouldn't be EINVAL but ENODEV. -- viresh