On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote: > The new added properties resource "reg" is for configuring > ethernet LDO in the IPQ5018 chipset, the property "clocks" > is for configuring the MDIO clock source frequency. > > This patch depends on the following patch: > Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO > driver") Please always make binding patches part of the series containing the driver code. We sometimes need to see both to do a proper review. Add a comment about when the second address range and clock is required. Does qcom,ipq5018-mdio require them? Andrew