Quoting Iskren Chernev (2021-08-01 03:34:47) > Add device tree bindings for global clock controller on SM6115 and > SM4250 SoCs (pin and software compatible). > > Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx> > --- > .../bindings/clock/qcom,gcc-sm6115.yaml | 74 +++++++ > include/dt-bindings/clock/qcom,gcc-sm6115.h | 201 ++++++++++++++++++ > 2 files changed, 275 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sm6115.yaml > create mode 100644 include/dt-bindings/clock/qcom,gcc-sm6115.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm6115.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm6115.yaml > new file mode 100644 > index 000000000000..c8c9eb82b9b4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm6115.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sm6115.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for SM6115 and SM4250 > + > +maintainers: > + - Iskren Chernev <iskren.chernev@xxxxxxxxx> > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on SM4250/6115. > + > + See also: > + - dt-bindings/clock/qcom,gcc-sm6115.h > + > +properties: > + compatible: > + const: qcom,gcc-sm6115 > + > + clocks: > + items: > + - description: Board XO source > + - description: Sleep clock source > + - description: PLL test clock source (Optional clock) Please drop this last one > + > + clock-names: > + items: > + - const: bi_tcxo > + - const: sleep_clk > + - const: core_bi_pll_test_se # Optional clock And this last one. The test input is never used. I'd make this the same as gcc-sc7180, i.e. have the always on XO as an input in case it is needed. > + > + '#clock-cells': > + const: 1