Rafael / Bjorn, On Fri, May 21, 2021 at 1:45 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > Let's delete the private function cpr_read_efuse() since it does the > basically the same thing as the new API call > nvmem_cell_read_variable_le_u32(). > > Differences between the new API call and the old private function: > * less error printing (I assume this is OK). > * will give an error if the value doesn't fit in 32-bits (the old code > would have truncated silently). > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > I haven't done any more than compile-test this. Mostly I'm just > writing this patch because it helped provide inspiration for the > general API function. > > Changes in v2: > - Resending v1 as a singleton patch; dependency is merged in mainline. > > drivers/soc/qcom/cpr.c | 43 +++++------------------------------------- > 1 file changed, 5 insertions(+), 38 deletions(-) Are either of you interested in landing this? I guess Rafael landed most of the recent changes to this driver, but it used to be under the 'power' directory. Now that it's under 'drivers/soc/qcom' maybe it should go through Bjorn's tree? -Doug