Re: [PATCH v3 2/7] drm/msm/dsi: add three helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20210709]
[cannot apply to v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/drm-msm-dpu-add-support-for-independent-DSI-config/20210711-062150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e16624d7b4376797ede36e3c955375cf0f23298
config: arm-randconfig-r016-20210711 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/d60158cc75b16689ac121290b562160916b57833
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dmitry-Baryshkov/drm-msm-dpu-add-support-for-independent-DSI-config/20210711-062150
        git checkout d60158cc75b16689ac121290b562160916b57833
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/msm/adreno/adreno_device.c:9:
   In file included from drivers/gpu/drm/msm/adreno/adreno_gpu.h:15:
   In file included from drivers/gpu/drm/msm/msm_gpu.h:16:
>> drivers/gpu/drm/msm/msm_drv.h:382:14: error: expected ';' after return statement
           return false
                       ^
                       ;
>> drivers/gpu/drm/msm/msm_drv.h:380:6: warning: no previous prototype for function 'msm_dsi_is_master_dsi' [-Wmissing-prototypes]
   bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi)
        ^
   drivers/gpu/drm/msm/msm_drv.h:380:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi)
   ^
   static 
   1 warning and 1 error generated.
--
   In file included from drivers/gpu/drm/msm/dp/dp_display.c:14:
>> drivers/gpu/drm/msm/msm_drv.h:382:14: error: expected ';' after return statement
           return false
                       ^
                       ;
>> drivers/gpu/drm/msm/msm_drv.h:380:6: warning: no previous prototype for function 'msm_dsi_is_master_dsi' [-Wmissing-prototypes]
   bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi)
        ^
   drivers/gpu/drm/msm/msm_drv.h:380:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi)
   ^
   static 
   drivers/gpu/drm/msm/dp/dp_display.c:1017:21: warning: variable 'drm' set but not used [-Wunused-but-set-variable]
           struct drm_device *drm;
                              ^
   2 warnings and 1 error generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for QCOM_SCM
   Depends on (ARM || ARM64) && HAVE_ARM_SMCCC
   Selected by
   - ARM_QCOM_SPM_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_QCOM || COMPILE_TEST && !ARM64 && MMU


vim +382 drivers/gpu/drm/msm/msm_drv.h

   339	
   340	struct msm_edp;
   341	void __init msm_edp_register(void);
   342	void __exit msm_edp_unregister(void);
   343	int msm_edp_modeset_init(struct msm_edp *edp, struct drm_device *dev,
   344			struct drm_encoder *encoder);
   345	
   346	struct msm_dsi;
   347	#ifdef CONFIG_DRM_MSM_DSI
   348	void __init msm_dsi_register(void);
   349	void __exit msm_dsi_unregister(void);
   350	int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev,
   351				 struct drm_encoder *encoder);
   352	void msm_dsi_snapshot(struct msm_disp_state *disp_state, struct msm_dsi *msm_dsi);
   353	bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi);
   354	bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi);
   355	bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi);
   356	#else
   357	static inline void __init msm_dsi_register(void)
   358	{
   359	}
   360	static inline void __exit msm_dsi_unregister(void)
   361	{
   362	}
   363	static inline int msm_dsi_modeset_init(struct msm_dsi *msm_dsi,
   364					       struct drm_device *dev,
   365					       struct drm_encoder *encoder)
   366	{
   367		return -EINVAL;
   368	}
   369	static inline void msm_dsi_snapshot(struct msm_disp_state *disp_state, struct msm_dsi *msm_dsi)
   370	{
   371	}
   372	static inline bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi)
   373	{
   374		return false;
   375	}
   376	static bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi)
   377	{
   378		return false;
   379	}
 > 380	bool msm_dsi_is_master_dsi(struct msm_dsi *msm_dsi)
   381	{
 > 382		return false
   383	}
   384	#endif
   385	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux