On Tue 06 Jul 18:07 CDT 2021, Bryan O'Donoghue wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
> fix issues with TypeC support.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
> Cc: robh+dt@xxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c0de12aaba6..270d7ff59ec1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
> <&gcc GCC_USB3_PHY_SEC_BCR>;
> reset-names = "phy", "common";
>
> - usb_2_ssphy: lane@88eb200 {
> + usb_2_ssphy: lanes@88eb200 {
The uni-phy binding says that this should be named "^phy@[0-9a-f]+$"
So while Dmitry is right about the logic in the driver, it would be nice
if you would spin this patch to make us pass the dt-binding check -
which can be sent independently from the driver patch.
Regards,
Bjorn
> reg = <0 0x088eb200 0 0x200>,
> <0 0x088eb400 0 0x200>,
> <0 0x088eb800 0 0x800>;
> --
> 2.30.1
>
